88 testpats = [ |
88 testpats = [ |
89 [ |
89 [ |
90 (r'pushd|popd', "don't use 'pushd' or 'popd', use 'cd'"), |
90 (r'pushd|popd', "don't use 'pushd' or 'popd', use 'cd'"), |
91 (r'\W\$?\(\([^\)\n]*\)\)', "don't use (()) or $(()), use 'expr'"), |
91 (r'\W\$?\(\([^\)\n]*\)\)', "don't use (()) or $(()), use 'expr'"), |
92 (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"), |
92 (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"), |
93 (r'(?<!hg )grep.*-a', "don't use 'grep -a', use in-line python"), |
93 (r'(?<!hg )grep.* -a', "don't use 'grep -a', use in-line python"), |
94 (r'sed.*-i', "don't use 'sed -i', use a temporary file"), |
94 (r'sed.*-i', "don't use 'sed -i', use a temporary file"), |
95 (r'\becho\b.*\\n', "don't use 'echo \\n', use printf"), |
95 (r'\becho\b.*\\n', "don't use 'echo \\n', use printf"), |
96 (r'echo -n', "don't use 'echo -n', use printf"), |
96 (r'echo -n', "don't use 'echo -n', use printf"), |
97 (r'(^|\|\s*)\bwc\b[^|]*$\n(?!.*\(re\))', "filter wc output"), |
97 (r'(^|\|\s*)\bwc\b[^|]*$\n(?!.*\(re\))', "filter wc output"), |
98 (r'head -c', "don't use 'head -c', use 'dd'"), |
98 (r'head -c', "don't use 'head -c', use 'dd'"), |