Mercurial > public > mercurial-scm > hg

comparison contrib/check-code.py @ 19081:e97ce4a5afc5 stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: expand sed rule to include more offenders Expands the rule added in 5e4491c114b2 to include cases where the address is a line number instead of a regular expression, and fixes an instance of this pattern in test-unionrepo.t.
author Kevin Bullock <kbullock@ringworld.org>
date Mon, 22 Apr 2013 16:50:08 -0500
parents 5e4491c114b2
children 12f15e4b2ca0
comparison
equal deleted inserted replaced
19080:5e4491c114b2 19081:e97ce4a5afc5
72 (r'^alias\b.*=', "don't use alias, use a function"), 72 (r'^alias\b.*=', "don't use alias, use a function"),
73 (r'if\s*!', "don't use '!' to negate exit status"), 73 (r'if\s*!', "don't use '!' to negate exit status"),
74 (r'/dev/u?random', "don't use entropy, use /dev/zero"), 74 (r'/dev/u?random', "don't use entropy, use /dev/zero"),
75 (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"), 75 (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"),
76 (r'^( *)\t', "don't use tabs to indent"), 76 (r'^( *)\t', "don't use tabs to indent"),
77 (r'sed .*\'/[^/]*/i[^\\][^\n]', 77 (r'sed .*\'(\d+|/[^/]*/)i[^\\][^\n]',
78 "put a backslash-escaped newline after sed 'i' command"), 78 "put a backslash-escaped newline after sed 'i' command"),
79 ], 79 ],
80 # warnings 80 # warnings
81 [ 81 [
82 (r'^function', "don't use 'function', use old style"), 82 (r'^function', "don't use 'function', use old style"),