comparison contrib/check-code.py @ 16485:f48b075ff088 stable

tests: solaris sh can not negate exit status with '!'
author Mads Kiilerich <mads@kiilerich.com>
date Mon, 23 Apr 2012 01:39:26 +0200
parents 3c4910364797
children ac987a9d8d49
comparison
equal deleted inserted replaced
16484:bf877ebed866 16485:f48b075ff088
71 (r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"), 71 (r'ls +[^|\n-]+ +-', "options to 'ls' must come before filenames"),
72 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"), 72 (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
73 (r'^stop\(\)', "don't use 'stop' as a shell function name"), 73 (r'^stop\(\)', "don't use 'stop' as a shell function name"),
74 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"), 74 (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
75 (r'^alias\b.*=', "don't use alias, use a function"), 75 (r'^alias\b.*=', "don't use alias, use a function"),
76 (r'if\s*!', "don't use '!' to negate exit status"),
76 ], 77 ],
77 # warnings 78 # warnings
78 [] 79 []
79 ] 80 ]
80 81