Mercurial > public > mercurial-scm > hg
comparison mercurial/utils/procutil.py @ 46019:fdd54a876213 stable
procutil: use rapply(tonativestr, ...) to preserve lists when they come in
This was broken when script was a list instead of a string. I caught this
with an internal extension at Google, and I'm not really sure why it wasn't
caught in any kind of CI.
Differential Revision: https://phab.mercurial-scm.org/D9471
| author | Augie Fackler <augie@google.com> |
|---|---|
| date | Tue, 01 Dec 2020 01:18:21 -0500 |
| parents | a37f290a7124 |
| children | 2cf61e66c6d0 |
comparison
equal
deleted
inserted
replaced
| 45851:81da6feb5000 | 46019:fdd54a876213 |
|---|---|
| 638 ): | 638 ): |
| 639 '''Spawn a command without waiting for it to finish.''' | 639 '''Spawn a command without waiting for it to finish.''' |
| 640 # we can't use close_fds *and* redirect stdin. I'm not sure that we | 640 # we can't use close_fds *and* redirect stdin. I'm not sure that we |
| 641 # need to because the detached process has no console connection. | 641 # need to because the detached process has no console connection. |
| 642 p = subprocess.Popen( | 642 p = subprocess.Popen( |
| 643 tonativestr(script), | 643 pycompat.rapply(tonativestr, script), |
| 644 shell=shell, | 644 shell=shell, |
| 645 env=tonativeenv(env), | 645 env=tonativeenv(env), |
| 646 close_fds=True, | 646 close_fds=True, |
| 647 creationflags=_creationflags, | 647 creationflags=_creationflags, |
| 648 stdout=stdout, | 648 stdout=stdout, |