Mercurial > public > mercurial-scm > hg
diff mercurial/cffi/mpatchbuild.py @ 36948:0585337ea787
cleanup: fix some latent open(path).read() et al calls we previously missed
This pattern was banned by check-code way back in 1b4b82063ce2 (may of
2011), but due to a regular expression rewriting bug in check-code
these particular callsites were never detected. Python 3.7 caught the
bug, which then exposed these errors.
Differential Revision: https://phab.mercurial-scm.org/D2863
| author | Augie Fackler <augie@google.com> |
|---|---|
| date | Wed, 14 Mar 2018 15:39:28 -0400 |
| parents | 2dcb3d52ef41 |
| children | 2372284d9457 |
line wrap: on
line diff
--- a/mercurial/cffi/mpatchbuild.py Wed Mar 14 11:16:45 2018 -0700 +++ b/mercurial/cffi/mpatchbuild.py Wed Mar 14 15:39:28 2018 -0400 @@ -6,8 +6,9 @@ ffi = cffi.FFI() mpatch_c = os.path.join(os.path.join(os.path.dirname(__file__), '..', 'mpatch.c')) -ffi.set_source("mercurial.cffi._mpatch", open(mpatch_c).read(), - include_dirs=["mercurial"]) +with open(mpatch_c) as f: + ffi.set_source("mercurial.cffi._mpatch", f.read(), + include_dirs=["mercurial"]) ffi.cdef(""" struct mpatch_frag {