Mercurial > public > mercurial-scm > hg
diff mercurial/windows.py @ 23682:1642eb429536
windows: quote the specified string only when it has to be quoted
Before this patch, "windows.shellquote" (as used as "util.shellquote")
always quotes specified strings with double quotation marks, for
external process invocation.
But some problematic applications can't work correctly, when command
line arguments are quoted: see issue4463 for detail.
On the other hand, quoting itself is needed to specify arguments
containing whitespaces and/or some special characters exactly.
This patch makes "windows.shellquote" examine the specified string and
quote it only when it may have to be quoted for safety.
| author | FUJIWARA Katsunori <foozy@lares.dti.ne.jp> |
|---|---|
| date | Thu, 25 Dec 2014 23:33:26 +0900 |
| parents | 234e4c24b980 |
| children | 7956d17431bc d65ecb814fc0 |
line wrap: on
line diff
--- a/mercurial/windows.py Thu Dec 25 23:33:26 2014 +0900 +++ b/mercurial/windows.py Thu Dec 25 23:33:26 2014 +0900 @@ -148,10 +148,20 @@ # backslash before every double quote (being careful with the double # quote we've appended to the end) _quotere = None +_needsshellquote = None def shellquote(s): global _quotere if _quotere is None: _quotere = re.compile(r'(\\*)("|\\$)') + global _needsshellquote + if _needsshellquote is None: + # ":" and "\\" are also treated as "safe character", because + # they are used as a part of path name (and the latter doesn't + # work as "escape character", like one on posix) on Windows + _needsshellquote = re.compile(r'[^a-zA-Z0-9._:/\\-]').search + if not _needsshellquote(s) and not _quotere.search(s): + # "s" shouldn't have to be quoted + return s return '"%s"' % _quotere.sub(r'\1\1\\\2', s) def quotecommand(cmd):