--- a/contrib/packaging/hgpackaging/cli.py Sat Feb 19 18:42:12 2022 -0700
+++ b/contrib/packaging/hgpackaging/cli.py Sat Feb 19 22:13:11 2022 -0700
@@ -20,13 +20,7 @@
SOURCE_DIR = HERE.parent.parent.parent
-def build_inno(pyoxidizer_target=None, python=None, iscc=None, version=None):
- if not pyoxidizer_target and not python:
- raise Exception("--python required unless building with PyOxidizer")
-
- if python and not os.path.isabs(python):
- raise Exception("--python arg must be an absolute path")
-
+def build_inno(pyoxidizer_target, iscc=None, version=None):
if iscc:
iscc = pathlib.Path(iscc)
else:
@@ -38,59 +32,30 @@
build_dir = SOURCE_DIR / "build"
- if pyoxidizer_target:
- inno.build_with_pyoxidizer(
- SOURCE_DIR, build_dir, pyoxidizer_target, iscc, version=version
- )
- else:
- inno.build_with_py2exe(
- SOURCE_DIR,
- build_dir,
- pathlib.Path(python),
- iscc,
- version=version,
- )
+ inno.build_with_pyoxidizer(
+ SOURCE_DIR, build_dir, pyoxidizer_target, iscc, version=version
+ )
def build_wix(
+ pyoxidizer_target,
name=None,
- pyoxidizer_target=None,
- python=None,
version=None,
sign_sn=None,
sign_cert=None,
sign_password=None,
sign_timestamp_url=None,
- extra_packages_script=None,
extra_wxs=None,
extra_features=None,
extra_pyoxidizer_vars=None,
):
- if not pyoxidizer_target and not python:
- raise Exception("--python required unless building with PyOxidizer")
-
- if python and not os.path.isabs(python):
- raise Exception("--python arg must be an absolute path")
-
kwargs = {
"source_dir": SOURCE_DIR,
"version": version,
+ "target_triple": pyoxidizer_target,
+ "extra_pyoxidizer_vars": extra_pyoxidizer_vars,
}
- if pyoxidizer_target:
- fn = wix.build_installer_pyoxidizer
- kwargs["target_triple"] = pyoxidizer_target
- kwargs["extra_pyoxidizer_vars"] = extra_pyoxidizer_vars
- else:
- fn = wix.build_installer_py2exe
- kwargs["python_exe"] = pathlib.Path(python)
-
- if extra_packages_script:
- if pyoxidizer_target:
- raise Exception(
- "pyoxidizer does not support --extra-packages-script"
- )
- kwargs["extra_packages_script"] = extra_packages_script
if extra_wxs:
kwargs["extra_wxs"] = dict(
thing.split("=") for thing in extra_wxs.split(",")
@@ -107,7 +72,7 @@
"timestamp_url": sign_timestamp_url,
}
- fn(**kwargs)
+ wix.build_installer_pyoxidizer(**kwargs)
def get_parser():
@@ -119,9 +84,9 @@
sp.add_argument(
"--pyoxidizer-target",
choices={"i686-pc-windows-msvc", "x86_64-pc-windows-msvc"},
+ required=True,
help="Build with PyOxidizer targeting this host triple",
)
- sp.add_argument("--python", help="path to python.exe to use")
sp.add_argument("--iscc", help="path to iscc.exe to use")
sp.add_argument(
"--version",
@@ -137,9 +102,9 @@
sp.add_argument(
"--pyoxidizer-target",
choices={"i686-pc-windows-msvc", "x86_64-pc-windows-msvc"},
+ required=True,
help="Build with PyOxidizer targeting this host triple",
)
- sp.add_argument("--python", help="Path to Python executable to use")
sp.add_argument(
"--sign-sn",
help="Subject name (or fragment thereof) of certificate "
@@ -155,12 +120,6 @@
)
sp.add_argument("--version", help="Version string to use")
sp.add_argument(
- "--extra-packages-script",
- help=(
- "Script to execute to include extra packages in " "py2exe binary."
- ),
- )
- sp.add_argument(
"--extra-wxs", help="CSV of path_to_wxs_file=working_dir_for_wxs_file"
)
sp.add_argument(