Mercurial > public > mercurial-scm > hg
diff tests/test-rename-merge2.t @ 27137:25e4b2f000c5
merge: move almost all change/delete conflicts to resolve phase (BC) (API)
We have finally laid all the groundwork to make this happen.
The only change/delete conflicts that haven't been moved are .hgsubstate
conflicts. Those are trickier to deal with and well outside the scope of this
series.
We add comprehensive testing not just for the initial selections but also for
re-resolves and all possible dirstate transitions caused by merge tools. That
testing managed to shake out several bugs in the way we were handling dirstate
transitions.
The other test changes are because we now treat change/delete conflicts as
proper merges, and increment the 'merged' counter rather than the 'updated'
counter. I believe this is the right approach here.
For third-party extensions, if they're interacting with filemerge code they
might have to deal with an absentfilectx rather than a regular filectx.
Still to come:
- add a 'leave unresolved' option to merges
- change the default for non-interactive change/delete conflicts to be 'leave
unresolved'
- add debug output to go alongside debug outputs for binary and symlink file
merges
author | Siddharth Agarwal <sid0@fb.com> |
---|---|
date | Wed, 25 Nov 2015 14:25:33 -0800 |
parents | d837da26155e |
children | 296d55def9c4 |
line wrap: on
line diff
--- a/tests/test-rename-merge2.t Wed Nov 25 14:26:46 2015 -0800 +++ b/tests/test-rename-merge2.t Wed Nov 25 14:25:33 2015 -0800 @@ -679,12 +679,12 @@ resolving manifests branchmerge: True, force: False, partial: False ancestor: 924404dff337, local: 02963e448370+, remote: 8dbce441892a + preserving b for resolve of b + preserving rev for resolve of rev + a: prompt deleted/changed -> m (premerge) + picked tool ':prompt' for a (binary False symlink False) remote changed a which local deleted use (c)hanged version or leave (d)eleted? c - preserving b for resolve of b - preserving rev for resolve of rev - a: prompt recreating -> g - getting a b: both created -> m (premerge) picked tool 'python ../merge' for b (binary False symlink False) merging b @@ -703,7 +703,7 @@ my rev@02963e448370+ other rev@8dbce441892a ancestor rev@924404dff337 launching merge tool: python ../merge *$TESTTMP/t/t/rev* * * (glob) merge tool returned: 0 - 1 files updated, 2 files merged, 0 files removed, 0 files unresolved + 0 files updated, 3 files merged, 0 files removed, 0 files unresolved (branch merge, don't forget to commit) -------------- M a @@ -721,11 +721,13 @@ resolving manifests branchmerge: True, force: False, partial: False ancestor: 924404dff337, local: 0b76e65c8289+, remote: bdb19105162a + preserving a for resolve of a + preserving b for resolve of b + preserving rev for resolve of rev + a: prompt changed/deleted -> m (premerge) + picked tool ':prompt' for a (binary False symlink False) local changed a which remote deleted use (c)hanged version or (d)elete? c - preserving b for resolve of b - preserving rev for resolve of rev - a: prompt keep -> am b: both created -> m (premerge) picked tool 'python ../merge' for b (binary False symlink False) merging b @@ -744,7 +746,7 @@ my rev@0b76e65c8289+ other rev@bdb19105162a ancestor rev@924404dff337 launching merge tool: python ../merge *$TESTTMP/t/t/rev* * * (glob) merge tool returned: 0 - 0 files updated, 2 files merged, 0 files removed, 0 files unresolved + 0 files updated, 3 files merged, 0 files removed, 0 files unresolved (branch merge, don't forget to commit) -------------- M b