Mercurial > public > mercurial-scm > hg

diff hgext/commitextras.py @ 33602:27fbca750b4d stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
commitextras: make sure keys contains ascii letters, numbers, '_' and '-' only
author Pulkit Goyal <7895pulkit@gmail.com>
date Fri, 28 Jul 2017 07:42:55 +0530
parents 3cfabb6cfd51
children 806351695c6a
line wrap: on
line diff
--- a/hgext/commitextras.py	Thu Jul 27 12:03:01 2017 -0700
+++ b/hgext/commitextras.py	Fri Jul 28 07:42:55 2017 +0530
@@ -9,6 +9,8 @@
 
 from __future__ import absolute_import
 
+import re
+
 from mercurial.i18n import _
 from mercurial import (
     commands,
@@ -52,6 +54,10 @@
                                 "KEY=VALUE format")
                         raise error.Abort(msg % raw)
                     k, v = raw.split('=', 1)
+                    if re.search('[^\w-]', k):
+                        msg = _("keys can only contain ascii letters, digits,"
+                                " '_' and '-'")
+                        raise error.Abort(msg)
                     if k in usedinternally:
                         msg = _("key '%s' is used internally, can't be set "
                                 "manually")