Mercurial > public > mercurial-scm > hg
diff mercurial/copies.py @ 43231:30570a056fa8
sidedatacopies: only store an entry if it has values
This will make for a shorter storage and help use to write faster code in simple
case. This change already provided a speed boost for copy tracing.
For example here is combined time of running copies tracing on a 6989 pairs of
revision on the pypy repos:
before: 771s
after: 631s - 18%
This also has a very positive impact on changelog size. For example here are the
number for the `00changelog.d` file of pypy.
before: 30449712 Bytes
after: 24973718 Bytes - 18%
This give an overall quite acceptable overhead for storing copies into the
changelog:
filelog-only: 23370586
sidedata: 24973718 Bytes + 7%
Differential Revision: https://phab.mercurial-scm.org/D7068
| author | Pierre-Yves David <pierre-yves.david@octobus.net> |
|---|---|
| date | Wed, 02 Oct 2019 14:38:34 -0400 |
| parents | 069cbbb53cdf |
| children | 32187ae9eeb3 |
line wrap: on
line diff
--- a/mercurial/copies.py Wed Oct 02 14:16:30 2019 -0400 +++ b/mercurial/copies.py Wed Oct 02 14:38:34 2019 -0400 @@ -890,10 +890,14 @@ p2copies = encodecopies(sortedfiles, p2copies) filesadded = encodefileindices(sortedfiles, filesadded) filesremoved = encodefileindices(sortedfiles, filesremoved) - sidedata[sidedatamod.SD_P1COPIES] = p1copies - sidedata[sidedatamod.SD_P2COPIES] = p2copies - sidedata[sidedatamod.SD_FILESADDED] = filesadded - sidedata[sidedatamod.SD_FILESREMOVED] = filesremoved + if p1copies: + sidedata[sidedatamod.SD_P1COPIES] = p1copies + if p2copies: + sidedata[sidedatamod.SD_P2COPIES] = p2copies + if filesadded: + sidedata[sidedatamod.SD_FILESADDED] = filesadded + if filesremoved: + sidedata[sidedatamod.SD_FILESREMOVED] = filesremoved return sidedata