diff contrib/check-code.py @ 16332:42e95631887d

tests: remove sed -i from test-record
author Matt Mackall <mpm@selenic.com>
date Sun, 01 Apr 2012 13:59:11 -0500
parents 0d175ac527c1
children 329887a7074c
line wrap: on
line diff
--- a/contrib/check-code.py	Sat Mar 31 15:39:44 2012 -0500
+++ b/contrib/check-code.py	Sun Apr 01 13:59:11 2012 -0500
@@ -47,6 +47,7 @@
     (r'\W\$?\(\([^\)\n]*\)\)', "don't use (()) or $(()), use 'expr'"),
     (r'^function', "don't use 'function', use old style"),
     (r'grep.*-q', "don't use 'grep -q', redirect to /dev/null"),
+    (r'sed.*-i', "don't use 'sed -i', use a temporary file"),
     (r'echo.*\\n', "don't use 'echo \\n', use printf"),
     (r'echo -n', "don't use 'echo -n', use printf"),
     (r'^diff.*-\w*N', "don't use 'diff -N'"),