Mercurial > public > mercurial-scm > hg

diff mercurial/wireprotoframing.py @ 39486:43d92d68ac88

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
wireprotov2peer: properly format errors formatrichmessage() expects an iterable containing dicts with well-defined keys. We were passing in something else. This caused an exception. Change the code to call formatrichmessage() with the proper argument. And add a TODO to potentially emit the proper data structure from the server in the first place. Differential Revision: https://phab.mercurial-scm.org/D4441
author Gregory Szorc <gregory.szorc@gmail.com>
date Wed, 05 Sep 2018 09:04:40 -0700
parents 36f487a332ad
children 07b58266bce3
line wrap: on
line diff
--- a/mercurial/wireprotoframing.py	Thu Aug 23 13:50:47 2018 -0700
+++ b/mercurial/wireprotoframing.py	Wed Sep 05 09:04:40 2018 -0700
@@ -419,6 +419,8 @@
                            payload=b'')
 
 def createcommanderrorresponse(stream, requestid, message, args=None):
+    # TODO should this be using a list of {'msg': ..., 'args': {}} so atom
+    # formatting works consistently?
     m = {
         b'status': b'error',
         b'error': {