Mercurial > public > mercurial-scm > hg
diff hgext/convert/common.py @ 19120:58e782f076e7
splicemap: improve error handling when source is hg (issue2084)
1. Introduced 2 levels of error handling for splicemap files
a. Check the splicemap file for rules which are same across different
types of source repos. This is done through enhancing parsesplicemap
function
b. Check revision string formats. Each repo may have their own format.
This is done usign checkrevformat function
c. Implemented the above two for hg
| author | Ben Goswami <bengoswami@fb.com> |
|---|---|
| date | Thu, 25 Apr 2013 11:50:26 -0700 |
| parents | 61f1223ab358 |
| children | 83973dc1bfe9 |
line wrap: on
line diff
--- a/hgext/convert/common.py Wed Apr 24 18:26:37 2013 -0700 +++ b/hgext/convert/common.py Thu Apr 25 11:50:26 2013 -0700 @@ -5,7 +5,7 @@ # This software may be used and distributed according to the terms of the # GNU General Public License version 2 or any later version. -import base64, errno, subprocess, os, datetime +import base64, errno, subprocess, os, datetime, re import cPickle as pickle from mercurial import util from mercurial.i18n import _ @@ -63,6 +63,15 @@ self.encoding = 'utf-8' + def checkhexformat(self, revstr): + """ fails if revstr is not a 40 byte hex. mercurial and git both uses + such format for their revision numbering + """ + matchobj = re.match(r'[0-9a-fA-F]{40,40}$', revstr) + if matchobj is None: + raise util.Abort(_('splicemap entry %s is not a valid revision' + ' identifier') % revstr) + def before(self): pass @@ -164,6 +173,13 @@ """ return {} + def checkrevformat(self, revstr): + """revstr is a string that describes a revision in the given + source control system. Return true if revstr has correct + format. + """ + return True + class converter_sink(object): """Conversion sink (target) interface"""