Mercurial > public > mercurial-scm > hg
diff hgext/convert/hg.py @ 48116:5ced12cfa41b
errors: raise InputError on bad revset to revrange() iff provided by the user
Most callers of `scmutil.revrange()` pass in a revset provided by the
user. If there are problems resolving that, it should result in an
`InputError` and exit code 10 (when using detailed exit
codes). However, there are also some callers that pass in revsets not
provided by the user. `InputError` is not appropriate in those
cases. This patch therefore introduces a wrapper around
`scmutil.revrange()` that simply converts the exception type. I put it
in `logcmdutil.py` since that seems to be the lowest-level module in
the (poorly defined) UI layer.
Differential Revision: https://phab.mercurial-scm.org/D11560
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Tue, 28 Sep 2021 08:47:11 -0700 |
parents | bea4717415c0 |
children | 7d1e60244561 |
line wrap: on
line diff
--- a/hgext/convert/hg.py Tue Sep 28 09:08:43 2021 -0700 +++ b/hgext/convert/hg.py Tue Sep 28 08:47:11 2021 -0700 @@ -36,10 +36,10 @@ exchange, hg, lock as lockmod, + logcmdutil, merge as mergemod, phases, pycompat, - scmutil, util, ) from mercurial.utils import dateutil @@ -564,7 +564,7 @@ ) nodes = set() parents = set() - for r in scmutil.revrange(self.repo, [hgrevs]): + for r in logcmdutil.revrange(self.repo, [hgrevs]): ctx = self.repo[r] nodes.add(ctx.node()) parents.update(p.node() for p in ctx.parents())