Mercurial > public > mercurial-scm > hg
diff mercurial/hg.py @ 48116:5ced12cfa41b
errors: raise InputError on bad revset to revrange() iff provided by the user
Most callers of `scmutil.revrange()` pass in a revset provided by the
user. If there are problems resolving that, it should result in an
`InputError` and exit code 10 (when using detailed exit
codes). However, there are also some callers that pass in revsets not
provided by the user. `InputError` is not appropriate in those
cases. This patch therefore introduces a wrapper around
`scmutil.revrange()` that simply converts the exception type. I put it
in `logcmdutil.py` since that seems to be the lowest-level module in
the (poorly defined) UI layer.
Differential Revision: https://phab.mercurial-scm.org/D11560
author | Martin von Zweigbergk <martinvonz@google.com> |
---|---|
date | Tue, 28 Sep 2021 08:47:11 -0700 |
parents | 1fdf315eff66 |
children | 1d70fb83ff4a |
line wrap: on
line diff
--- a/mercurial/hg.py Tue Sep 28 09:08:43 2021 -0700 +++ b/mercurial/hg.py Tue Sep 28 08:47:11 2021 -0700 @@ -1352,7 +1352,7 @@ ui.status(_(b'comparing with %s\n') % urlutil.hidepassword(dest)) revs, checkout = addbranchrevs(repo, repo, branches, opts.get(b'rev')) if revs: - revs = [repo[rev].node() for rev in scmutil.revrange(repo, revs)] + revs = [repo[rev].node() for rev in logcmdutil.revrange(repo, revs)] other = peer(repo, opts, dest) try: