Mercurial > public > mercurial-scm > hg

diff rust/hg-cpython/src/vfs.rs @ 52294:645d247d4c75

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
rust-vfs: rename `open` to `open_write` and `open_read` to `open` `open` being read *and* write is surprising because it differs from the Rust stdlib where `std::fs::File::open` is read-only by default. More importantly, writing is more dangerous than reading, so let's make it more explicit.
author Rapha?l Gom?s <rgomes@octobus.net>
date Tue, 29 Oct 2024 12:03:55 +0100
parents 8d35941689af
children
line wrap: on
line diff
--- a/rust/hg-cpython/src/vfs.rs	Tue Oct 29 11:41:27 2024 +0100
+++ b/rust/hg-cpython/src/vfs.rs	Tue Oct 29 12:03:55 2024 +0100
@@ -142,11 +142,12 @@
 
 impl Vfs for PyVfs {
     fn open(&self, filename: &Path) -> Result<VfsFile, HgError> {
-        self.inner_open(filename, false, false, false, true)
+        self.inner_open(filename, false, false, false, false)
             .map(|(f, _)| VfsFile::normal(f, filename.to_owned()))
     }
-    fn open_read(&self, filename: &Path) -> Result<VfsFile, HgError> {
-        self.inner_open(filename, false, false, false, false)
+
+    fn open_write(&self, filename: &Path) -> Result<VfsFile, HgError> {
+        self.inner_open(filename, false, false, false, true)
             .map(|(f, _)| VfsFile::normal(f, filename.to_owned()))
     }