Mercurial > public > mercurial-scm > hg
diff hgext/largefiles/lfcommands.py @ 22296:650b5b6e75ed
convert: use None value for missing files instead of overloading IOError
The internal API used IOError to indicate that a file should be marked as
removed.
There is some correlation between IOError (especially with ENOENT) and files
that should be removed, but using IOErrors to represent file removal internally
required some hacks.
Instead, use the value None to indicate that the file not is present.
Before, spurious IO errors could cause commits that silently removed files.
They will now be reported like all other IO errors so the root cause can be
fixed.
| author | Mads Kiilerich <madski@unity3d.com> |
|---|---|
| date | Tue, 26 Aug 2014 22:03:32 +0200 |
| parents | f72d73937853 |
| children | e53f6b72a0e4 1265a3a71d75 |
line wrap: on
line diff
--- a/hgext/largefiles/lfcommands.py Wed Aug 27 12:30:28 2014 +0200 +++ b/hgext/largefiles/lfcommands.py Tue Aug 26 22:03:32 2014 +0200 @@ -146,7 +146,7 @@ try: fctx = ctx.filectx(lfutil.standin(f)) except error.LookupError: - raise IOError + return None renamed = fctx.renamed() if renamed: renamed = lfutil.splitstandin(renamed[0]) @@ -248,7 +248,7 @@ try: fctx = ctx.filectx(srcfname) except error.LookupError: - raise IOError + return None renamed = fctx.renamed() if renamed: # standin is always a largefile because largefile-ness @@ -298,7 +298,7 @@ try: fctx = ctx.filectx(f) except error.LookupError: - raise IOError + return None renamed = fctx.renamed() if renamed: renamed = renamed[0]