Mercurial > public > mercurial-scm > hg

diff mercurial/debugcommands.py @ 37645:72b0982cd509

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
debugcommands: perform handshake when obtaining httpv2 peer If we obtain an httpv2peer directly, the instance doesn't have an API descriptor and therefore doesn't know about the remote's commands, feature support, etc. This doesn't matter now. But when we implement the peer so it consults the API descriptor as part of sending commands, it will. So we change the logic for obtaining an http version 2 peer to go through makepeer() so the peer will perform the handshake and pass the API descriptor to the httpv2peer instance. Tests changed because we now perform a ?cmd=capabilities when obtaining version 2 peers. The Content-Length header is globbed because compression info will lack zstandard for pure builds. Differential Revision: https://phab.mercurial-scm.org/D3296
author Gregory Szorc <gregory.szorc@gmail.com>
date Thu, 12 Apr 2018 12:33:07 -0700
parents 77c9ee77687c
children 516b5a5edae3
line wrap: on
line diff
--- a/mercurial/debugcommands.py	Wed Apr 11 18:15:51 2018 -0700
+++ b/mercurial/debugcommands.py	Thu Apr 12 12:33:07 2018 -0700
@@ -83,7 +83,6 @@
     vfs as vfsmod,
     wireprotoframing,
     wireprotoserver,
-    wireprototypes,
 )
 from .utils import (
     dateutil,
@@ -2911,9 +2910,19 @@
 
         if opts['peer'] == 'http2':
             ui.write(_('creating http peer for wire protocol version 2\n'))
-            peer = httppeer.httpv2peer(
-                ui, path, 'api/%s' % wireprototypes.HTTP_WIREPROTO_V2,
-                opener, httppeer.urlreq.request, {})
+            # We go through makepeer() because we need an API descriptor for
+            # the peer instance to be useful.
+            with ui.configoverride({
+                ('experimental', 'httppeer.advertise-v2'): True}):
+                peer = httppeer.makepeer(ui, path, opener=opener)
+
+            if not isinstance(peer, httppeer.httpv2peer):
+                raise error.Abort(_('could not instantiate HTTP peer for '
+                                    'wire protocol version 2'),
+                                  hint=_('the server may not have the feature '
+                                         'enabled or is not allowing this '
+                                         'client version'))
+
         elif opts['peer'] == 'raw':
             ui.write(_('using raw connection to peer\n'))
             peer = None