Mercurial > public > mercurial-scm > hg
diff contrib/chg/chg.c @ 28789:7f6e0a15189b
chg: replace abortmsg showing errno with abortmsgerrno
Since we have abortmsgerrno now, use it to show human friendly error messages
across platforms.
author | Jun Wu <quark@fb.com> |
---|---|
date | Tue, 05 Apr 2016 15:16:01 +0100 |
parents | ea86cdcd9b50 |
children | b0cc9652e8dc |
line wrap: on
line diff
--- a/contrib/chg/chg.c Tue Apr 05 17:25:39 2016 +0100 +++ b/contrib/chg/chg.c Tue Apr 05 15:16:01 2016 +0100 @@ -114,13 +114,12 @@ int r; r = mkdir(sockdir, 0700); if (r < 0 && errno != EEXIST) - abortmsg("cannot create sockdir %s (errno = %d)", - sockdir, errno); + abortmsgerrno("cannot create sockdir %s", sockdir); struct stat st; r = lstat(sockdir, &st); if (r < 0) - abortmsg("cannot stat %s (errno = %d)", sockdir, errno); + abortmsgerrno("cannot stat %s", sockdir); if (!S_ISDIR(st.st_mode)) abortmsg("cannot create sockdir %s (file exists)", sockdir); if (st.st_uid != geteuid() || st.st_mode & 0077) @@ -166,11 +165,12 @@ if (opts->lockfd == -1) { opts->lockfd = open(opts->lockfile, O_RDWR | O_CREAT | O_NOFOLLOW, 0600); if (opts->lockfd == -1) - abortmsg("cannot create lock file %s", opts->lockfile); + abortmsgerrno("cannot create lock file %s", + opts->lockfile); } int r = flock(opts->lockfd, LOCK_EX); if (r == -1) - abortmsg("cannot acquire lock"); + abortmsgerrno("cannot acquire lock"); } /* @@ -224,9 +224,9 @@ argv[argsize - 1] = NULL; if (putenv("CHGINTERNALMARK=") != 0) - abortmsg("failed to putenv (errno = %d)", errno); + abortmsgerrno("failed to putenv"); if (execvp(hgcmd, (char **)argv) < 0) - abortmsg("failed to exec cmdserver (errno = %d)", errno); + abortmsgerrno("failed to exec cmdserver"); free(argv); } @@ -325,7 +325,7 @@ { assert(peerpid > 0); if (kill(peerpid, sig) < 0) - abortmsg("cannot kill %d (errno = %d)", peerpid, errno); + abortmsgerrno("cannot kill %d", peerpid); debugmsg("forward signal %d", sig); } @@ -358,7 +358,7 @@ return; error: - abortmsg("failed to handle stop signal (errno = %d)", errno); + abortmsgerrno("failed to handle stop signal"); } static void setupsignalhandler(pid_t pid) @@ -397,7 +397,7 @@ return; error: - abortmsg("failed to set up signal handlers (errno = %d)", errno); + abortmsgerrno("failed to set up signal handlers"); } /* This implementation is based on hgext/pager.py (pre 369741ef7253) */ @@ -432,8 +432,7 @@ int r = execlp("/bin/sh", "/bin/sh", "-c", pagercmd, NULL); if (r < 0) { - abortmsg("cannot start pager '%s' (errno = %d)", - pagercmd, errno); + abortmsgerrno("cannot start pager '%s'", pagercmd); } return; } @@ -441,7 +440,7 @@ error: close(pipefds[0]); close(pipefds[1]); - abortmsg("failed to prepare pager (errno = %d)", errno); + abortmsgerrno("failed to prepare pager"); } /* Run instructions sent from the server like unlink and set redirect path @@ -514,7 +513,7 @@ { debugmsg("execute original hg"); if (execvp(gethgcmd(), (char **)argv) < 0) - abortmsg("failed to exec original hg (errno = %d)", errno); + abortmsgerrno("failed to exec original hg"); } int main(int argc, const char *argv[], const char *envp[])