Mercurial > public > mercurial-scm > hg
diff tests/test-command-template.t @ 34330:89aec1834a86
templatekw: add new-style template expansion to {manifest}
The goal is to allow us to easily access to nested data. The dot operator
will be introduced later so we can write '{p1.files}' instead of
'{revset("p1()") % "{files}"}' for example.
In the example above, 'p1' needs to carry a mapping dict along with its
string representation. If it were a list or a dict, it could be wrapped
semi-transparently with the _hybrid class, but for non-list/dict types,
it would be difficult to proxy all necessary functions to underlying value
type because several core operations may conflict with the ones of the
underlying value:
- hash(value) should be different from hash(wrapped(value)), which means
dict[wrapped(value)] would be invalid
- 'value == wrapped(value)' would be false, breaks 'ifcontains'
- len(wrapped(value)) may be either len(value) or len(iter(wrapped(value)))
So the wrapper has no proxy functions and its scope designed to be minimal.
It's unwrapped at eval*() functions so we don't have to care for a wrapped
object unless it's really needed:
# most template functions just call evalfuncarg()
unwrapped_value = evalfuncarg(context, mapping, args[n])
# if wrapped value is needed, use evalrawexp()
maybe_wrapped_value = evalrawexp(context, mapping, args[n])
Another idea was to wrap every template variable with a tagging class, but
which seemed uneasy without a static type checker.
This patch updates {manifest} to a mappable as an example.
author | Yuya Nishihara <yuya@tcha.org> |
---|---|
date | Sun, 24 Apr 2016 18:41:23 +0900 |
parents | 6367318327f0 |
children | b3073e175c17 |
line wrap: on
line diff
--- a/tests/test-command-template.t Mon Apr 24 21:37:11 2017 +0900 +++ b/tests/test-command-template.t Sun Apr 24 18:41:23 2016 +0900 @@ -3119,6 +3119,20 @@ hg: parse error: None is not iterable [255] +Test new-style inline templating of non-list/dict type: + + $ hg log -R latesttag -r tip -T '{manifest}\n' + 11:2bc6e9006ce2 + $ hg log -R latesttag -r tip -T 'string length: {manifest|count}\n' + string length: 15 + $ hg log -R latesttag -r tip -T '{manifest % "{rev}:{node}"}\n' + 11:2bc6e9006ce29882383a22d39fd1f4e66dd3e2fc + +Test manifest can be join()-ed as before, though it's silly: + + $ hg log -R latesttag -r tip -T '{join(manifest, "")}\n' + 11:2bc6e9006ce2 + Test the sub function of templating for expansion: $ hg log -R latesttag -r 10 --template '{sub("[0-9]", "x", "{rev}")}\n'