Mercurial > public > mercurial-scm > hg
diff contrib/check-code.py @ 11341:920a783e5f91
check-code: fix check for any/all function
The old check would only detect any/all at the beginning of a line.
The regexp was probably just modeled after the preceding regexp which
(correctly) finds the 'with' keyword at the beginning of a line.
We now complain about 'any(' and 'all(' anywhere in a line, unless it
is preceded by 'def'. This allows us to define our own compatibility
wrapper in util and use 'util.any(' in the code.
| author | Martin Geisler <mg@aragost.com> |
|---|---|
| date | Tue, 15 Jun 2010 09:51:52 +0200 |
| parents | 0c0088881562 |
| children | f325db39c8b9 |
line wrap: on
line diff
--- a/contrib/check-code.py Mon Jun 14 16:56:20 2010 -0300 +++ b/contrib/check-code.py Tue Jun 15 09:51:52 2010 +0200 @@ -92,7 +92,7 @@ (r'[\x80-\xff]', "non-ASCII character literal"), (r'("\')\.format\(', "str.format() not available in Python 2.4"), (r'^\s*with\s+', "with not available in Python 2.4"), - (r'^\s*(any|all)\(', "any/all not available in Python 2.4"), + (r'(?<!def)\s+(any|all)\(', "any/all not available in Python 2.4"), (r'if\s.*\selse', "if ... else form not available in Python 2.4"), (r'([\(\[]\s\S)|(\S\s[\)\]])', "gratuitous whitespace in () or []"), # (r'\s\s=', "gratuitous whitespace before ="),