Mercurial > public > mercurial-scm > hg
diff mercurial/localrepo.py @ 14076:924c82157d46
url: move URL parsing functions into util to improve startup time
The introduction of the new URL parsing code has created a startup
time regression. This is mainly due to the use of url.hasscheme() in
the ui class. It ends up importing many libraries that the url module
requires.
This fix helps marginally, but if we can get rid of the urllib import
in the URL parser all together, startup time will go back to normal.
perfstartup time before the URL refactoring (8796fb6af67e):
! wall 0.050692 comb 0.000000 user 0.000000 sys 0.000000 (best of 100)
current startup time (139fb11210bb):
! wall 0.070685 comb 0.000000 user 0.000000 sys 0.000000 (best of 100)
after this change:
! wall 0.064667 comb 0.000000 user 0.000000 sys 0.000000 (best of 100)
| author | Brodie Rao <brodie@bitheap.org> |
|---|---|
| date | Sat, 30 Apr 2011 09:43:20 -0700 |
| parents | 72c84f24b420 |
| children | 7f45b1911893 |
line wrap: on
line diff
--- a/mercurial/localrepo.py Sat Apr 30 16:33:47 2011 +0200 +++ b/mercurial/localrepo.py Sat Apr 30 09:43:20 2011 -0700 @@ -14,7 +14,6 @@ import match as matchmod import merge as mergemod import tags as tagsmod -import url as urlmod from lock import release import weakref, errno, os, time, inspect propertycache = util.propertycache @@ -1695,7 +1694,7 @@ cl.delayupdate() oldheads = cl.heads() - tr = self.transaction("\n".join([srctype, urlmod.hidepassword(url)])) + tr = self.transaction("\n".join([srctype, util.hidepassword(url)])) try: trp = weakref.proxy(tr) # pull off the changeset group @@ -1937,7 +1936,7 @@ return a def instance(ui, path, create): - return localrepository(ui, urlmod.localpath(path), create) + return localrepository(ui, util.localpath(path), create) def islocal(path): return True