Mercurial > public > mercurial-scm > hg
diff rust/hg-core/src/lib.rs @ 42437:9609430d3625
rust-filepatterns: use bytes instead of String
In my initial patch, I introduced an unnecessary hard constraint on UTF-8
filenames and patterns which I forgot to remove. Although the performance
penalty for using String might be negligible, we don't want to break
compatibility with non-UTF-8 encodings for no reason.
Moreover, this change allows for a cleaner Rust core API.
This patch introduces a new utils module that is used with this fix.
Finally, PatternError was not put inside the Python module generated by
Rust, which would have raised a NameError.
Differential Revision: https://phab.mercurial-scm.org/D6485
author | Rapha?l Gom?s <rgomes@octobus.net> |
---|---|
date | Thu, 06 Jun 2019 15:30:56 +0200 |
parents | d3b5cbe311d9 |
children | 2dcee6497b0b |
line wrap: on
line diff
--- a/rust/hg-core/src/lib.rs Sat Jun 01 01:24:49 2019 +0200 +++ b/rust/hg-core/src/lib.rs Thu Jun 06 15:30:56 2019 +0200 @@ -19,6 +19,7 @@ CopyVec, CopyVecEntry, DirstateEntry, DirstateParents, DirstateVec, }; mod filepatterns; +mod utils; pub use filepatterns::{ build_single_regex, read_pattern_file, PatternSyntax, PatternTuple,