Mercurial > public > mercurial-scm > hg
diff tests/test-check-interfaces.py @ 37441:a3202fa83aff
filelog: declare that filelog implements a storage interface
Now that we have a declared interface, let's declare that filelog
implements it.
Tests have been added that confirm the object conforms to the
interface.
The existing interface checks verify there are no extra public
attributes outside the declared interface. filelog has several
extra attributes. So we added a mechanism to suppress this check.
The goal is to modify the filelog class so we can drop this check.
Differential Revision: https://phab.mercurial-scm.org/D3149
| author | Gregory Szorc <gregory.szorc@gmail.com> |
|---|---|
| date | Thu, 05 Apr 2018 15:18:23 -0700 |
| parents | 39f7d4ee8bcd |
| children | 93397c4633f6 |
line wrap: on
line diff
--- a/tests/test-check-interfaces.py Thu Apr 05 15:09:41 2018 -0700 +++ b/tests/test-check-interfaces.py Thu Apr 05 15:18:23 2018 -0700 @@ -12,6 +12,7 @@ ) from mercurial import ( bundlerepo, + filelog, httppeer, localrepo, repository, @@ -19,13 +20,14 @@ statichttprepo, ui as uimod, unionrepo, + vfs as vfsmod, wireprotoserver, wireprototypes, ) rootdir = os.path.normpath(os.path.join(os.path.dirname(__file__), '..')) -def checkzobject(o): +def checkzobject(o, allowextra=False): """Verify an object with a zope interface.""" ifaces = zi.providedBy(o) if not ifaces: @@ -37,6 +39,9 @@ for iface in ifaces: ziverify.verifyObject(iface, o) + if allowextra: + return + # Now verify that the object provides no extra public attributes that # aren't declared as part of interfaces. allowed = set() @@ -132,4 +137,10 @@ httpv2 = wireprotoserver.httpv2protocolhandler(None, None) checkzobject(httpv2) + ziverify.verifyClass(repository.ifilestorage, filelog.filelog) + + vfs = vfsmod.vfs('.') + fl = filelog.filelog(vfs, 'dummy.i') + checkzobject(fl, allowextra=True) + main()