Mercurial > public > mercurial-scm > hg

diff tests/test-check-code.t @ 20688:a61ed1c2d7a7

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: disallow use of dict(key=value) construction {} literals are faster and more consistent across Python 2 and 3. Whitelisted the one use of dict() that is using a generator expresion.
author Augie Fackler <raf@durin42.com>
date Wed, 12 Mar 2014 13:31:27 -0400
parents 22154ec6fb8b
children e8ef59b351c3
line wrap: on
line diff
--- a/tests/test-check-code.t	Wed Mar 12 13:29:29 2014 -0400
+++ b/tests/test-check-code.t	Wed Mar 12 13:31:27 2014 -0400
@@ -123,6 +123,7 @@
   $ cat > python3-compat.py << EOF
   > foo <> bar
   > reduce(lambda a, b: a + b, [1, 2, 3, 4])
+  > dict(key=value)
   > EOF
   $ "$check_code" python3-compat.py
   python3-compat.py:1:
@@ -131,6 +132,9 @@
   python3-compat.py:2:
    > reduce(lambda a, b: a + b, [1, 2, 3, 4])
    reduce is not available in Python 3+
+  python3-compat.py:3:
+   > dict(key=value)
+   dict() is different in Py2 and 3 and is slower than {}
   [1]
 
   $ cat > is-op.py <<EOF