Mercurial > public > mercurial-scm > hg
diff contrib/check-code.py @ 14763:b071cd58af50 stable
check-code: fix class style checking (with tests)
- old-style classes were only checked for one-letter class names
- add check for new-style classes with empty parent class, because
this is not available in Python 2.4
| author | Thomas Arendsen Hein <thomas@intevation.de> |
|---|---|
| date | Wed, 29 Jun 2011 13:45:51 +0200 |
| parents | 6c7283faa967 |
| children | 0407b7613e99 |
line wrap: on
line diff
--- a/contrib/check-code.py Wed Jun 29 00:19:27 2011 +0200 +++ b/contrib/check-code.py Wed Jun 29 13:45:51 2011 +0200 @@ -128,7 +128,9 @@ # (r'\w*[a-z][A-Z]\w*\s*=', "don't use camelcase in identifiers"), (r'^\s*(if|while|def|class|except|try)\s[^[]*:\s*[^\]#\s]+', "linebreak after :"), - (r'class\s[^(]:', "old-style class, use class foo(object)"), + (r'class\s[^( ]+:', "old-style class, use class foo(object)"), + (r'class\s[^( ]+\(\):', + "class foo() not available in Python 2.4, use class foo(object)"), (r'\b(%s)\(' % '|'.join(keyword.kwlist), "Python keyword is not a function"), (r',]', "unneeded trailing ',' in list"),