Mercurial > public > mercurial-scm > hg
diff hgext/shelve.py @ 22199:b3e51675f98e
cleanup: avoid _ for local unused tmp variables - that is reserved for i18n
_ is usually used for i18n markup but we also used it for I-don't-care
variables.
Instead, name don't-care variables in a slightly descriptive way but use the _
prefix to designate unused variable.
This will mute some pyflakes "import '_' ... shadowed by loop variable"
warnings.
| author | Mads Kiilerich <madski@unity3d.com> |
|---|---|
| date | Fri, 15 Aug 2014 16:20:47 +0200 |
| parents | fb8065de47b0 |
| children | 684bad8c4265 |
line wrap: on
line diff
--- a/hgext/shelve.py Fri Aug 15 04:37:45 2014 +0200 +++ b/hgext/shelve.py Fri Aug 15 16:20:47 2014 +0200 @@ -269,7 +269,7 @@ wlock = None try: wlock = repo.wlock() - for (name, _) in repo.vfs.readdir('shelved'): + for (name, _type) in repo.vfs.readdir('shelved'): suffix = name.rsplit('.', 1)[-1] if suffix in ('hg', 'files', 'patch'): shelvedfile(repo, name).unlink() @@ -303,7 +303,7 @@ raise return [] info = [] - for (name, _) in names: + for (name, _type) in names: pfx, sfx = name.rsplit('.', 1) if not pfx or sfx != 'patch': continue