diff mercurial/commands.py @ 16705:c2d9ef43ff6c

check-code: ignore naked excepts with a "re-raise" comment This also promotes the naked except check from a warning to an error.
author Brodie Rao <brodie@sf.io>
date Sun, 13 May 2012 13:18:06 +0200
parents de2267517841
children 4a02cf4fbb2e
line wrap: on
line diff
--- a/mercurial/commands.py	Sun May 13 13:17:50 2012 +0200
+++ b/mercurial/commands.py	Sun May 13 13:18:06 2012 +0200
@@ -3775,7 +3775,7 @@
                 tr.close()
             if msgs:
                 repo.savecommitmessage('\n* * *\n'.join(msgs))
-        except:
+        except: # re-raises
             # wlock.release() indirectly calls dirstate.write(): since
             # we're crashing, we do not want to change the working dir
             # parent after all, so make sure it writes nothing