Mercurial > public > mercurial-scm > hg
diff contrib/check-code.py @ 15611:ec8a49c46d7e
merge with stable
author | Matt Mackall <mpm@selenic.com> |
---|---|
date | Mon, 05 Dec 2011 17:48:40 -0600 |
parents | 53ef627cda30 fab28a577a38 |
children | a153a86a472c |
line wrap: on
line diff
--- a/contrib/check-code.py Fri Dec 02 18:36:32 2011 +0100 +++ b/contrib/check-code.py Mon Dec 05 17:48:40 2011 -0600 @@ -88,7 +88,7 @@ (r'^(\S| $ ).*(\S[ \t]+|^[ \t]+)\n', "trailing whitespace on non-output"), (uprefix + r'.*\|\s*sed', "use regex test output patterns instead of sed"), (uprefix + r'(true|exit 0)', "explicit zero exit unnecessary"), - (uprefix + r'.*\$\?', "explicit exit code checks unnecessary"), + (uprefix + r'.*(?<!\[)\$\?', "explicit exit code checks unnecessary"), (uprefix + r'.*\|\| echo.*(fail|error)', "explicit exit code checks unnecessary"), (uprefix + r'set -e', "don't use set -e"),