Mercurial > public > mercurial-scm > hg
diff mercurial/pure/parsers.py @ 38847:f3d394ea17db
index: handle index[-1] as nullid more explicitly
I find it more intuitive to check if "pos == -1" than to first add the
index length (which includes one extra item for the nullid) and
compare that to "length - 1". However, because test-parseindex2.py
compares the whole index (up to len(index)-1), we need to also
preserve that other check for a little while more. I'll remove it
soon.
Differential Revision: https://phab.mercurial-scm.org/D4018
| author | Martin von Zweigbergk <martinvonz@google.com> |
|---|---|
| date | Fri, 20 Jul 2018 09:53:54 -0700 |
| parents | 644a02f6b34f |
| children | c0d411ea6639 |
line wrap: on
line diff
--- a/mercurial/pure/parsers.py Fri Jul 20 22:26:28 2018 -0700 +++ b/mercurial/pure/parsers.py Fri Jul 20 09:53:54 2018 -0700 @@ -55,9 +55,9 @@ return i def __getitem__(self, i): + if i == -1 or i == len(self) - 1: + return (0, 0, 0, -1, -1, -1, -1, nullid) i = self._fix_index(i) - if i == len(self) - 1: - return (0, 0, 0, -1, -1, -1, -1, nullid) if i >= self._lgt: return self._extra[i - self._lgt] index = self._calculate_index(i)