Mercurial > public > mercurial-scm > hg

diff hgext/mq.py @ 8527:f9a80054dd3c

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
use 'x is None' instead of 'x == None' The built-in None object is a singleton and it is therefore safe to compare memory addresses with is. It is also faster, how much depends on the object being compared. For a simple type like str I get: | s = "foo" | s = None ----------+-----------+---------- s == None | 0.25 usec | 0.21 usec s is None | 0.17 usec | 0.17 usec
author Martin Geisler <mg@lazybytes.net>
date Wed, 20 May 2009 00:52:46 +0200
parents b169ba60eebe
children 2b3dec0ef3ae
line wrap: on
line diff
--- a/hgext/mq.py	Wed May 20 00:43:23 2009 +0200
+++ b/hgext/mq.py	Wed May 20 00:52:46 2009 +0200
@@ -430,7 +430,7 @@
         if ret:
             raise util.Abort(_("update returned %d") % ret)
         n = repo.commit(None, ctx.description(), ctx.user(), force=1)
-        if n == None:
+        if n is None:
             raise util.Abort(_("repo commit failed"))
         try:
             ph = mergeq.readheaders(patch)
@@ -603,7 +603,7 @@
             n = repo.commit(files, message, ph.user, ph.date, match=match,
                             force=True)
 
-            if n == None:
+            if n is None:
                 raise util.Abort(_("repo commit failed"))
 
             if update_status:
@@ -767,7 +767,7 @@
                     msg = msg()
                 commitmsg = msg and msg or ("[mq]: %s" % patchfn)
                 n = repo.commit(commitfiles, commitmsg, user, date, match=match, force=True)
-                if n == None:
+                if n is None:
                     raise util.Abort(_("repo commit failed"))
                 try:
                     self.full_series[insert:insert] = [patchfn]
@@ -860,7 +860,7 @@
                     return self.series[0]
             return None
 
-        if patch == None:
+        if patch is None:
             return None
         if patch in self.series:
             return patch
@@ -1422,7 +1422,7 @@
                     applied.append(se)
                 else:
                     series.append(file_)
-        if datastart == None:
+        if datastart is None:
             self.ui.warn(_("No saved patch data found\n"))
             return 1
         self.ui.warn(_("restoring status: %s\n") % lines[0])
@@ -1486,7 +1486,7 @@
         if len(self.applied) > 0:
             p = self.applied[-1].name
             end = self.find_series(p)
-            if end == None:
+            if end is None:
                 return len(self.full_series)
             return end + 1
         return 0
@@ -2090,7 +2090,7 @@
         m = namere.match(f)
         if m:
             index = int(m.group(1))
-            if maxindex == None or index > maxindex:
+            if maxindex is None or index > maxindex:
                 maxindex = index
                 maxname = f
     if maxname: