Mercurial > public > mercurial-scm > hg
view rust/hg-cpython/src/exceptions.rs @ 51238:578c049f0408
rust-index: using `hg::index::Index` in `hg-cpython::dagops`
Hooking `headrevs` to the Rust index is straightforward as long as
we go the `PySharedRef` way. Direct attempts of obtaining a reference
to the inner `hg::index::Index` fail for lifetime reasons: the reference
is bound to the GIL, yet the `as_set` local variable is considered to
be static (the borrow checker clearly does not realize or care that this
set only stores `Revision` values).
In `rank()`, the chosen solution is the simplest as far as `hg-cpython` is
concerned, but it has the defect of removing an implementation
that would be easily adaptable if the core index did implement `RankedGraph`
(returning the same error as long as only `REVLOGV1` is supported), but that
would introduce a direct dependency of `hg-core` on the ``vcsgraph` crate.
author | Georges Racinet <georges.racinet@octobus.net> |
---|---|
date | Sun, 29 Oct 2023 10:47:54 +0100 |
parents | 4c5f6e95df84 |
children | 2fb13c3f4496 |
line wrap: on
line source
// ancestors.rs // // Copyright 2018 Georges Racinet <gracinet@anybox.fr> // // This software may be used and distributed according to the terms of the // GNU General Public License version 2 or any later version. //! Bindings for Rust errors //! //! [`GraphError`] exposes `hg::GraphError` as a subclass of `ValueError` //! but some variants of `hg::GraphError` can be converted directly to other //! existing Python exceptions if appropriate. //! //! [`GraphError`]: struct.GraphError.html use cpython::{ exc::{RuntimeError, ValueError}, py_exception, PyErr, Python, }; use hg; use crate::PyRevision; py_exception!(rustext, GraphError, ValueError); impl GraphError { pub fn pynew(py: Python, inner: hg::GraphError) -> PyErr { match inner { hg::GraphError::ParentOutOfRange(r) => { GraphError::new(py, ("ParentOutOfRange", PyRevision(r.0))) } } } pub fn pynew_from_vcsgraph( py: Python, inner: vcsgraph::graph::GraphReadError, ) -> PyErr { match inner { vcsgraph::graph::GraphReadError::InconsistentGraphData => { GraphError::new(py, "InconsistentGraphData") } vcsgraph::graph::GraphReadError::InvalidKey => { GraphError::new(py, "ParentOutOfRange") } vcsgraph::graph::GraphReadError::KeyedInvalidKey(r) => { GraphError::new(py, ("ParentOutOfRange", r)) } vcsgraph::graph::GraphReadError::WorkingDirectoryUnsupported => { match py .import("mercurial.error") .and_then(|m| m.get(py, "WdirUnsupported")) { Err(e) => e, Ok(cls) => PyErr::from_instance(py, cls), } } } } } py_exception!(rustext, HgPathPyError, RuntimeError); py_exception!(rustext, FallbackError, RuntimeError); py_exception!(shared_ref, AlreadyBorrowed, RuntimeError);