Mercurial > public > mercurial-scm > hg
view mercurial/revlogutils/concurrency_checker.py @ 52049:af54626bf358
dirstate-map: add a missing debug wait point when accessing the v2 docket
fc8e37c380d3 added synchronization points to the dirstate to allow for race
condition testing without actually requiring a time-based race condition
to happen.
This changes adds the `pre-read-file` wait point before we read the docket,
since callers might ask for the parents before anything else is
read, leading to the first read being done before the wait point.
This removes some differences in test output which were presumed to be
speed related, but weren't.
author | Rapha?l Gom?s <rgomes@octobus.net> |
---|---|
date | Mon, 14 Oct 2024 14:14:21 +0200 |
parents | 1c5810ce737e |
children |
line wrap: on
line source
from __future__ import annotations from ..i18n import _ from .. import error def get_checker(ui, revlog_name=b'changelog'): """Get a function that checks file handle position is as expected. This is used to ensure that files haven't been modified outside of our knowledge (such as on a networked filesystem, if `hg debuglocks` was used, or writes to .hg that ignored locks happened). Due to revlogs supporting a concept of buffered, delayed, or diverted writes, we're allowing the files to be shorter than expected (the data may not have been written yet), but they can't be longer. Please note that this check is not perfect; it can't detect all cases (there may be false-negatives/false-OKs), but it should never claim there's an issue when there isn't (false-positives/false-failures). """ vpos = ui.config(b'debug', b'revlog.verifyposition.' + revlog_name) # Avoid any `fh.tell` cost if this isn't enabled. if not vpos or vpos not in [b'log', b'warn', b'fail']: return None def _checker(fh, fn, expected): if fh.tell() <= expected: return msg = _(b'%s: file cursor at position %d, expected %d') # Always log if we're going to warn or fail. ui.log(b'debug', msg + b'\n', fn, fh.tell(), expected) if vpos == b'warn': ui.warn((msg + b'\n') % (fn, fh.tell(), expected)) elif vpos == b'fail': raise error.RevlogError(msg % (fn, fh.tell(), expected)) return _checker