Mercurial > public > mercurial-scm > hg
view contrib/lock-checker.py @ 20056:cbcd85fa75c0 stable
share: fix unshare calling wrong repo.__init__() method
When running the unshare command, if there's other code that tries to use
the repo after the command is finished, it'll end up with a ui object for
repo.unfiltered(). This change fixes an erroneous call to repo.__init__()
that could be on the repoview proxy class--now it's always done on the
unfiltered repo.
author | Brodie Rao <brodie@sf.io> |
---|---|
date | Sat, 16 Nov 2013 17:30:34 -0500 |
parents | b8424c92ba2b |
children | 47d0843647d1 |
line wrap: on
line source
"""Extension to verify locks are obtained in the required places. This works by wrapping functions that should be surrounded by a lock and asserting the lock is held. Missing locks are called out with a traceback printed to stderr. This currently only checks store locks, not working copy locks. """ import os import traceback def _warnstack(ui, msg, skip=1): '''issue warning with the message and the current stack, skipping the skip last entries''' ui.warn('%s at:\n' % msg) entries = traceback.extract_stack()[:-skip] fnmax = max(len(entry[0]) for entry in entries) for fn, ln, func, _text in entries: ui.warn(' %*s:%-4s in %s\n' % (fnmax, fn, ln, func)) def _checklock(repo): l = repo._lockref and repo._lockref() if l is None or not l.held: _warnstack(repo.ui, 'missing lock', skip=2) def reposetup(ui, repo): orig = repo.__class__ class lockcheckrepo(repo.__class__): def _writejournal(self, *args, **kwargs): _checklock(self) return orig._writejournal(self, *args, **kwargs) def transaction(self, *args, **kwargs): _checklock(self) return orig.transaction(self, *args, **kwargs) # TODO(durin42): kiilerix had a commented-out lock check in # _writebranchcache and _writerequirements def _tag(self, *args, **kwargs): _checklock(self) return orig._tag(self, *args, **kwargs) def write(self, *args, **kwargs): assert os.path.lexists(self._join('.hg/wlock')) return orig.write(self, *args, **kwargs) repo.__class__ = lockcheckrepo