Mercurial > public > mercurial-scm > hg
view rust/chg/src/runcommand.rs @ 48178:f12a19d03d2c
fix: reduce number of tool executions
By grouping together (path, ctx) pairs according to the inputs they would
provide to fixer tools, we can deduplicate executions of fixer tools to
significantly reduce the amount of time spent running slow tools.
This change does not handle clean files in the working copy, which could still
be deduplicated against the files in the checked out commit. It's a little
harder to do that because the filerev is not available in the workingfilectx
(and it doesn't exist for added files).
Anecdotally, this change makes some real uses cases at Google 10x faster. I
think we were originally hesitant to do this because the benefits weren't
obvious, and implementing it efficiently is kind of tricky. If we simply
memoized the formatter execution function, we would be keeping tons of file
content in memory.
Also included is a regression test for a corner case that I broke with my first
attempt at optimizing this code.
Differential Revision: https://phab.mercurial-scm.org/D11280
author | Danny Hooper <hooper@google.com> |
---|---|
date | Thu, 02 Sep 2021 14:08:45 -0700 |
parents | 426294d06ddc |
children |
line wrap: on
line source
// Copyright 2018 Yuya Nishihara <yuya@tcha.org> // // This software may be used and distributed according to the terms of the // GNU General Public License version 2 or any later version. //! Functions to run Mercurial command in cHg-aware command server. use bytes::Bytes; use std::io; use std::os::unix::io::AsRawFd; use tokio_hglib::codec::ChannelMessage; use tokio_hglib::{Connection, Protocol}; use crate::attachio; use crate::message::{self, CommandType}; use crate::uihandler::SystemHandler; /// Runs the given Mercurial command in cHg-aware command server, and /// fetches the result code. /// /// This is a subset of tokio-hglib's `run_command()` with the additional /// SystemRequest support. pub async fn run_command( proto: &mut Protocol<impl Connection + AsRawFd>, handler: &mut impl SystemHandler, packed_args: impl Into<Bytes>, ) -> io::Result<i32> { proto .send_command_with_args("runcommand", packed_args) .await?; loop { match proto.fetch_response().await? { ChannelMessage::Data(b'r', data) => { return message::parse_result_code(data); } ChannelMessage::Data(..) => { // just ignores data sent to optional channel } ChannelMessage::InputRequest(..) | ChannelMessage::LineRequest(..) => { return Err(io::Error::new( io::ErrorKind::InvalidData, "unsupported request", )); } ChannelMessage::SystemRequest(data) => { let (cmd_type, cmd_spec) = message::parse_command_spec(data)?; match cmd_type { CommandType::Pager => { // server spins new command loop while pager request is // in progress, which can be terminated by "" command. let pin = handler.spawn_pager(&cmd_spec).await?; attachio::attach_io(proto, &io::stdin(), &pin, &pin) .await?; proto.send_command("").await?; // terminator } CommandType::System => { let code = handler.run_system(&cmd_spec).await?; let data = message::pack_result_code(code); proto.send_data(data).await?; } } } } } }