Mercurial > public > mercurial-scm > hg
view rust/chg/src/uihandler.rs @ 48178:f12a19d03d2c
fix: reduce number of tool executions
By grouping together (path, ctx) pairs according to the inputs they would
provide to fixer tools, we can deduplicate executions of fixer tools to
significantly reduce the amount of time spent running slow tools.
This change does not handle clean files in the working copy, which could still
be deduplicated against the files in the checked out commit. It's a little
harder to do that because the filerev is not available in the workingfilectx
(and it doesn't exist for added files).
Anecdotally, this change makes some real uses cases at Google 10x faster. I
think we were originally hesitant to do this because the benefits weren't
obvious, and implementing it efficiently is kind of tricky. If we simply
memoized the formatter execution function, we would be keeping tons of file
content in memory.
Also included is a regression test for a corner case that I broke with my first
attempt at optimizing this code.
Differential Revision: https://phab.mercurial-scm.org/D11280
author | Danny Hooper <hooper@google.com> |
---|---|
date | Thu, 02 Sep 2021 14:08:45 -0700 |
parents | 426294d06ddc |
children |
line wrap: on
line source
// Copyright 2018 Yuya Nishihara <yuya@tcha.org> // // This software may be used and distributed according to the terms of the // GNU General Public License version 2 or any later version. use async_trait::async_trait; use std::io; use std::os::unix::io::AsRawFd; use std::os::unix::process::ExitStatusExt; use std::process::Stdio; use tokio; use tokio::process::{Child, ChildStdin, Command}; use crate::message::CommandSpec; use crate::procutil; /// Callback to process shell command requests received from server. #[async_trait] pub trait SystemHandler { type PagerStdin: AsRawFd; /// Handles pager command request. /// /// Returns the pipe to be attached to the server if the pager is spawned. async fn spawn_pager( &mut self, spec: &CommandSpec, ) -> io::Result<Self::PagerStdin>; /// Handles system command request. /// /// Returns command exit code (positive) or signal number (negative). async fn run_system(&mut self, spec: &CommandSpec) -> io::Result<i32>; } /// Default cHg implementation to process requests received from server. pub struct ChgUiHandler { pager: Option<Child>, } impl ChgUiHandler { pub fn new() -> ChgUiHandler { ChgUiHandler { pager: None } } /// Waits until the pager process exits. pub async fn wait_pager(&mut self) -> io::Result<()> { if let Some(p) = self.pager.take() { p.await?; } Ok(()) } } #[async_trait] impl SystemHandler for ChgUiHandler { type PagerStdin = ChildStdin; async fn spawn_pager( &mut self, spec: &CommandSpec, ) -> io::Result<Self::PagerStdin> { let mut pager = new_shell_command(&spec).stdin(Stdio::piped()).spawn()?; let pin = pager.stdin.take().unwrap(); procutil::set_blocking_fd(pin.as_raw_fd())?; // TODO: if pager exits, notify the server with SIGPIPE immediately. // otherwise the server won't get SIGPIPE if it does not write // anything. (issue5278) // kill(peerpid, SIGPIPE); self.pager = Some(pager); Ok(pin) } async fn run_system(&mut self, spec: &CommandSpec) -> io::Result<i32> { let status = new_shell_command(&spec).spawn()?.await?; let code = status .code() .or_else(|| status.signal().map(|n| -n)) .expect("either exit code or signal should be set"); Ok(code) } } fn new_shell_command(spec: &CommandSpec) -> Command { let mut builder = Command::new("/bin/sh"); builder .arg("-c") .arg(&spec.command) .current_dir(&spec.current_dir) .env_clear() .envs(spec.envs.iter().cloned()); builder }