diff -r 3da652f2039c -r 3c80ecdc1bcd mercurial/ui.py
--- a/mercurial/ui.py	Tue Dec 18 14:01:42 2007 -0600
+++ b/mercurial/ui.py	Wed Dec 05 20:40:01 2007 +0900
@@ -440,9 +440,7 @@
             f.write(text)
             f.close()
 
-            editor = (os.environ.get("HGEDITOR") or
-                    self.config("ui", "editor") or
-                    os.environ.get("EDITOR", "vi"))
+            editor = self.geteditor()
 
             util.system("%s \"%s\"" % (editor, name),
                         environ={'HGUSER': user},
@@ -464,3 +462,11 @@
         if self.traceback:
             traceback.print_exc()
         return self.traceback
+
+    def geteditor(self):
+        '''return editor to use'''
+        return (os.environ.get("HGEDITOR") or
+                self.config("ui", "editor") or
+                os.environ.get("VISUAL") or
+                os.environ.get("EDITOR", "vi"))
+