diff -r a58f7f809fa5 -r bbb43c5b753a mercurial/match.py --- a/mercurial/match.py Tue Dec 17 01:16:59 2024 -0500 +++ b/mercurial/match.py Tue Dec 17 01:18:54 2024 -0500 @@ -1736,8 +1736,7 @@ syntax = b'relre:' patterns = [] - fp = open(filepath, 'rb') - if True: + with open(filepath, 'rb') as fp: for lineno, line in enumerate(fp, start=1): if b"#" in line: global _commentre @@ -1779,5 +1778,5 @@ patterns.append((linesyntax + line, lineno, line)) else: patterns.append(linesyntax + line) - fp.close() + return patterns