diff -r dea2a17cbfd0 -r be8a866a2c44 contrib/check-code.py --- a/contrib/check-code.py Wed Mar 29 12:37:03 2017 -0700 +++ b/contrib/check-code.py Wed Mar 29 16:46:57 2017 -0700 @@ -337,6 +337,8 @@ (r'^import httplib', "don't use httplib, use util.httplib"), (r'^import BaseHTTPServer', "use util.httpserver instead"), (r'\.next\(\)', "don't use .next(), use next(...)"), + (r'([a-z]*).revision\(\1\.node\(', + "don't covert rev to node before passing to revision(nodeorrev)"), # rules depending on implementation of repquote() (r' x+[xpqo%APM][\'"]\n\s+[\'"]x',