diff -r 2889d4574726 -r d4addef0ec74 contrib/check-code.py
--- a/contrib/check-code.py	Sat Oct 15 14:19:24 2011 -0500
+++ b/contrib/check-code.py	Mon Oct 17 00:11:56 2011 +0200
@@ -69,6 +69,7 @@
     (r'ls\s+[^|-]+\s+-', "options to 'ls' must come before filenames"),
     (r'[^>]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
     (r'stop\(\)', "don't use 'stop' as a shell function name"),
+    (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
   ],
   # warnings
   []