diff -r aeeb2afcdc25 -r ebeac9c41456 contrib/check-code.py
--- a/contrib/check-code.py	Sun Oct 16 20:26:20 2011 -0500
+++ b/contrib/check-code.py	Sun Oct 16 22:15:43 2011 -0500
@@ -69,6 +69,7 @@
     (r'ls\s+[^|\n-]+\s+-', "options to 'ls' must come before filenames"),
     (r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
     (r'stop\(\)', "don't use 'stop' as a shell function name"),
+    (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
   ],
   # warnings
   []