diff -r fc19f8ab8199 -r f2f460cdb4f5 mercurial/mdiff.py
--- a/mercurial/mdiff.py	Wed Nov 06 15:29:08 2019 -0500
+++ b/mercurial/mdiff.py	Wed Nov 06 15:35:21 2019 -0500
@@ -38,6 +38,7 @@
 splitnewlines = bdiff.splitnewlines
 
 
+# TODO: this looks like it could be an attrs, which might help pytype
 class diffopts(object):
     '''context is the number of context lines
     text treats all files as text
@@ -52,6 +53,8 @@
     upgrade generates git diffs to avoid data loss
     '''
 
+    _HAS_DYNAMIC_ATTRIBUTES = True
+
     defaults = {
         b'context': 3,
         b'text': False,