# HG changeset patch
# User Pulkit Goyal <7895pulkit@gmail.com>
# Date 1513945631 -19800
# Node ID 3ad582b2895cfd814bd9383d49256483caa20229
# Parent  ded3a63f305b5144400c9925d1cc6e2bc8a46a6d
repoview: add visibilityexceptions as an optional argument to repo.filtered()

This will help us in having an API where we can pass the filtername and the
visibilityexceptions to get a new repo object.

Visibility exceptions are the revs which must be visible even they should in
theory belong to the hidden set. They are required as there has been desire to
have a functionality to access hidden changesets using certain commands without
passing --hidden. After this patch we can make those changesets visibility
exceptions so that we can access them without requiring a unfiltered repo.

Differential Revision: https://phab.mercurial-scm.org/D1746

diff -r ded3a63f305b -r 3ad582b2895c mercurial/localrepo.py
--- a/mercurial/localrepo.py	Sun Dec 24 11:46:13 2017 -0700
+++ b/mercurial/localrepo.py	Fri Dec 22 17:57:11 2017 +0530
@@ -675,10 +675,10 @@
         Intended to be overwritten by filtered repo."""
         return self
 
-    def filtered(self, name):
+    def filtered(self, name, visibilityexceptions=None):
         """Return a filtered version of a repository"""
         cls = repoview.newtype(self.unfiltered().__class__)
-        return cls(self, name)
+        return cls(self, name, visibilityexceptions)
 
     @repofilecache('bookmarks', 'bookmarks.current')
     def _bookmarks(self):
diff -r ded3a63f305b -r 3ad582b2895c mercurial/repoview.py
--- a/mercurial/repoview.py	Sun Dec 24 11:46:13 2017 -0700
+++ b/mercurial/repoview.py	Fri Dec 22 17:57:11 2017 +0530
@@ -187,11 +187,14 @@
     subclasses of `localrepo`. Eg: `bundlerepo` or `statichttprepo`.
     """
 
-    def __init__(self, repo, filtername):
+    def __init__(self, repo, filtername, visibilityexceptions=None):
         object.__setattr__(self, r'_unfilteredrepo', repo)
         object.__setattr__(self, r'filtername', filtername)
         object.__setattr__(self, r'_clcachekey', None)
         object.__setattr__(self, r'_clcache', None)
+        # revs which are exceptions and must not be hidden
+        object.__setattr__(self, r'_visibilityexceptions',
+                           visibilityexceptions)
 
     # not a propertycache on purpose we shall implement a proper cache later
     @property
@@ -227,11 +230,11 @@
         """Return an unfiltered version of a repo"""
         return self._unfilteredrepo
 
-    def filtered(self, name):
+    def filtered(self, name, visibilityexceptions=None):
         """Return a filtered version of a repository"""
-        if name == self.filtername:
+        if name == self.filtername and not visibilityexceptions:
             return self
-        return self.unfiltered().filtered(name)
+        return self.unfiltered().filtered(name, visibilityexceptions)
 
     def __repr__(self):
         return r'<%s:%s %r>' % (self.__class__.__name__,