# HG changeset patch # User Sean Farley # Date 1501284996 25200 # Node ID f9134e96ed0f03271296e7659e887fbfe5857f90 # Parent f93975a5ebe8e0e96c8c1220ee6cb2a0e49cc9b9 clone: add tests for unsafe ssh url (SEC) diff -r f93975a5ebe8 -r f9134e96ed0f tests/test-clone.t --- a/tests/test-clone.t Tue Aug 01 14:40:19 2017 -0700 +++ b/tests/test-clone.t Fri Jul 28 16:36:36 2017 -0700 @@ -1092,3 +1092,25 @@ adding remote bookmark bookA updating working directory 1 files updated, 0 files merged, 0 files removed, 0 files unresolved + +SEC: check for unsafe ssh url + + $ hg clone 'ssh://-oProxyCommand=touch${IFS}owned/path' + abort: potentially unsafe url: 'ssh://-oProxyCommand=touch${IFS}owned/path' + [255] + $ hg clone 'ssh://%2DoProxyCommand=touch${IFS}owned/path' + abort: potentially unsafe url: 'ssh://-oProxyCommand=touch${IFS}owned/path' + [255] + $ hg clone 'ssh://fakehost|shellcommand/path' + abort: potentially unsafe url: 'ssh://fakehost|shellcommand/path' + [255] + $ hg clone 'ssh://fakehost%7Cshellcommand/path' + abort: potentially unsafe url: 'ssh://fakehost|shellcommand/path' + [255] + + $ hg clone 'ssh://-oProxyCommand=touch owned%20foo@example.com/nonexistent/path' + abort: potentially unsafe url: 'ssh://-oProxyCommand=touch owned foo@example.com/nonexistent/path' + [255] +We should not have created a file named owned - if it exists, the +attack succeeded. + $ if test -f owned; then echo 'you got owned'; fi