Mercurial > public > mercurial-scm > python-hglib
annotate tests/test-clone.py @ 188:5609a21fe39a
client: fail gracefully on unexpected prompts (issue5516)
Right now, if hglib encounters an unexpected prompt, it fails with a rather
opaque "unexpected data on required channel 'L'" error message. Furthermore,
if subsequently another command is called on the same client instance, both
the client and server processes lock up hard (at least on Windows), and the
server process rapidly leaks ~2GB of memory.
Fix this by responding with an empty string to any unexpected prompt. This
will trigger an "abort: response expected" exception from the server, which
is easily handled as a CommandError, and subsequent commands sent from the
same client work as expected.
This doesn't completely resolve bug 5516, as unexpected requests on another
required channel (e.g. I) can still cause a lockup.
However, it does fix the most common case of an unexpected password prompt.
author | G?bor Stefanik <gabor.stefanik@nng.com> |
---|---|
date | Tue, 12 Sep 2017 13:16:36 -0400 |
parents | 820d7c1e470a |
children |
rev | line source |
---|---|
93
a4fcece7dd8e
hglib: add top level clone method
Idan Kamara <idankk86@gmail.com>
parents:
diff
changeset
|
1 import os |
148
c1b966866ed7
hglib: make all imports absolute (issue4520)
Brett Cannon <brett@python.org>
parents:
143
diff
changeset
|
2 from tests import common |
93
a4fcece7dd8e
hglib: add top level clone method
Idan Kamara <idankk86@gmail.com>
parents:
diff
changeset
|
3 import hglib |
143
4359cabcb0cc
hglib: move string literals in the test code to util.b() (issue4520)
Brett Cannon <brett@python.org>
parents:
93
diff
changeset
|
4 from hglib.util import b |
93
a4fcece7dd8e
hglib: add top level clone method
Idan Kamara <idankk86@gmail.com>
parents:
diff
changeset
|
5 |
a4fcece7dd8e
hglib: add top level clone method
Idan Kamara <idankk86@gmail.com>
parents:
diff
changeset
|
6 class test_clone(common.basetest): |
a4fcece7dd8e
hglib: add top level clone method
Idan Kamara <idankk86@gmail.com>
parents:
diff
changeset
|
7 def test_basic(self): |
a4fcece7dd8e
hglib: add top level clone method
Idan Kamara <idankk86@gmail.com>
parents:
diff
changeset
|
8 self.append('a', 'a') |
143
4359cabcb0cc
hglib: move string literals in the test code to util.b() (issue4520)
Brett Cannon <brett@python.org>
parents:
93
diff
changeset
|
9 self.client.commit(b('first'), addremove=True) |
4359cabcb0cc
hglib: move string literals in the test code to util.b() (issue4520)
Brett Cannon <brett@python.org>
parents:
93
diff
changeset
|
10 cloned = hglib.clone(b('.'), b('cloned')) |
93
a4fcece7dd8e
hglib: add top level clone method
Idan Kamara <idankk86@gmail.com>
parents:
diff
changeset
|
11 self.assertRaises(ValueError, cloned.log) |
a4fcece7dd8e
hglib: add top level clone method
Idan Kamara <idankk86@gmail.com>
parents:
diff
changeset
|
12 cloned.open() |
a4fcece7dd8e
hglib: add top level clone method
Idan Kamara <idankk86@gmail.com>
parents:
diff
changeset
|
13 self.assertEquals(self.client.log(), cloned.log()) |
184
820d7c1e470a
hglib: fix hg clone --uncompressed option typo (issue5458)
Long Vu <long@tlvu.ca>
parents:
148
diff
changeset
|
14 |
820d7c1e470a
hglib: fix hg clone --uncompressed option typo (issue5458)
Long Vu <long@tlvu.ca>
parents:
148
diff
changeset
|
15 def test_clone_uncompressed(self): |
820d7c1e470a
hglib: fix hg clone --uncompressed option typo (issue5458)
Long Vu <long@tlvu.ca>
parents:
148
diff
changeset
|
16 hglib.clone(b('.'), b('cloned'), uncompressed=True) |