Mercurial > public > mercurial-scm > python-hglib

annotate tests/test-forget.py @ 188:5609a21fe39a

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
client: fail gracefully on unexpected prompts (issue5516) Right now, if hglib encounters an unexpected prompt, it fails with a rather opaque "unexpected data on required channel 'L'" error message. Furthermore, if subsequently another command is called on the same client instance, both the client and server processes lock up hard (at least on Windows), and the server process rapidly leaks ~2GB of memory. Fix this by responding with an empty string to any unexpected prompt. This will trigger an "abort: response expected" exception from the server, which is easily handled as a CommandError, and subsequent commands sent from the same client work as expected. This doesn't completely resolve bug 5516, as unexpected requests on another required channel (e.g. I) can still cause a lockup. However, it does fix the most common case of an unexpected password prompt.
author G?bor Stefanik <gabor.stefanik@nng.com>
date Tue, 12 Sep 2017 13:16:36 -0400
parents c1b966866ed7
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
148
c1b966866ed7 hglib: make all imports absolute (issue4520)
Brett Cannon <brett@python.org>
parents: 143
diff changeset
1 from tests import common
143
4359cabcb0cc hglib: move string literals in the test code to util.b() (issue4520)
Brett Cannon <brett@python.org>
parents: 31
diff changeset
2 from hglib.util import b
31
ee8863882aae client: add forget command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
3
ee8863882aae client: add forget command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
4 class test_forget(common.basetest):
ee8863882aae client: add forget command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
5 def test_basic(self):
ee8863882aae client: add forget command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
6 self.append('a', 'a')
143
4359cabcb0cc hglib: move string literals in the test code to util.b() (issue4520)
Brett Cannon <brett@python.org>
parents: 31
diff changeset
7 self.client.add([b('a')])
4359cabcb0cc hglib: move string literals in the test code to util.b() (issue4520)
Brett Cannon <brett@python.org>
parents: 31
diff changeset
8 self.assertTrue(self.client.forget(b('a')))
31
ee8863882aae client: add forget command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
9
ee8863882aae client: add forget command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
10 def test_warnings(self):
143
4359cabcb0cc hglib: move string literals in the test code to util.b() (issue4520)
Brett Cannon <brett@python.org>
parents: 31
diff changeset
11 self.assertFalse(self.client.forget(b('a')))
31
ee8863882aae client: add forget command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
12 self.append('a', 'a')
143
4359cabcb0cc hglib: move string literals in the test code to util.b() (issue4520)
Brett Cannon <brett@python.org>
parents: 31
diff changeset
13 self.client.add([b('a')])
4359cabcb0cc hglib: move string literals in the test code to util.b() (issue4520)
Brett Cannon <brett@python.org>
parents: 31
diff changeset
14 self.assertFalse(self.client.forget([b('a'), b('b')]))