annotate tests/test-init.py @ 188:5609a21fe39a

client: fail gracefully on unexpected prompts (issue5516) Right now, if hglib encounters an unexpected prompt, it fails with a rather opaque "unexpected data on required channel 'L'" error message. Furthermore, if subsequently another command is called on the same client instance, both the client and server processes lock up hard (at least on Windows), and the server process rapidly leaks ~2GB of memory. Fix this by responding with an empty string to any unexpected prompt. This will trigger an "abort: response expected" exception from the server, which is easily handled as a CommandError, and subsequent commands sent from the same client work as expected. This doesn't completely resolve bug 5516, as unexpected requests on another required channel (e.g. I) can still cause a lockup. However, it does fix the most common case of an unexpected password prompt.
author G?bor Stefanik <gabor.stefanik@nng.com>
date Tue, 12 Sep 2017 13:16:36 -0400
parents c1b966866ed7
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
148
c1b966866ed7 hglib: make all imports absolute (issue4520)
Brett Cannon <brett@python.org>
parents: 143
diff changeset
1 from tests import common
c1b966866ed7 hglib: make all imports absolute (issue4520)
Brett Cannon <brett@python.org>
parents: 143
diff changeset
2 import hglib, shutil
143
4359cabcb0cc hglib: move string literals in the test code to util.b() (issue4520)
Brett Cannon <brett@python.org>
parents: 92
diff changeset
3 from hglib.util import b
60
ce516ed9bc0d hglib: add init command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
4
ce516ed9bc0d hglib: add init command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
5 class test_init(common.basetest):
ce516ed9bc0d hglib: add init command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
6 def test_exists(self):
ce516ed9bc0d hglib: add init command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
7 self.assertRaises(hglib.error.CommandError, hglib.init)
ce516ed9bc0d hglib: add init command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
8
ce516ed9bc0d hglib: add init command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
9 def test_basic(self):
ce516ed9bc0d hglib: add init command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
10 self.client.close()
ce516ed9bc0d hglib: add init command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
11 self.client = None
ce516ed9bc0d hglib: add init command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
12 shutil.rmtree('.hg')
ce516ed9bc0d hglib: add init command
Idan Kamara <idankk86@gmail.com>
parents:
diff changeset
13
92
07efbd3bd09a hglib: change init to not open a command server instance automatically
Idan Kamara <idankk86@gmail.com>
parents: 60
diff changeset
14 self.client = hglib.init().open()
143
4359cabcb0cc hglib: move string literals in the test code to util.b() (issue4520)
Brett Cannon <brett@python.org>
parents: 92
diff changeset
15 self.assertTrue(self.client.root().endswith(b('test_init')))