Mercurial > public > mercurial-scm > python-hglib
view tests/with_hg.py @ 176:3f854e3bcdd1 2.2
client: raise KeyError from __getitem__ (BC)
object.__getitem__ is supposed to raise either IndexError or KeyError
(depending on whether the thing is a sequence or a mapping). Before,
we would raise ValueError because that's what the context constructor
raises.
I choose to raise KeyError because IndexError felt a bit too limiting.
This does sacrifice some magic with for loops handling IndexError.
However, iteration of this object should be handled by a custom
__iter__, so I don't think this is a problem.
author | Gregory Szorc <gregory.szorc@gmail.com> |
---|---|
date | Wed, 06 Jul 2016 14:14:22 -0700 |
parents | f4f636ecca3e |
children |
line wrap: on
line source
import os from nose.plugins import Plugin class WithHgPlugin(Plugin): name = 'with-hg' enabled = False def options(self, parser, env): Plugin.options(self, parser, env) parser.add_option('--with-hg', action='store', type='string', metavar='HG', dest='with_hg', help='test using specified hg script.') def configure(self, options, conf): Plugin.configure(self, options, conf) if options.with_hg: self.enabled = True self.hgpath = os.path.realpath(options.with_hg) def begin(self): import hglib p = hglib.util.popen([self.hgpath, 'version']) p.communicate() if p.returncode: raise ValueError("custom hg %r doesn't look like Mercurial" % self.hgpath) hglib.HGPATH = self.hgpath