Mercurial > public > mercurial-scm > python-hglib
view tests/common.py @ 188:5609a21fe39a
client: fail gracefully on unexpected prompts (issue5516)
Right now, if hglib encounters an unexpected prompt, it fails with a rather
opaque "unexpected data on required channel 'L'" error message. Furthermore,
if subsequently another command is called on the same client instance, both
the client and server processes lock up hard (at least on Windows), and the
server process rapidly leaks ~2GB of memory.
Fix this by responding with an empty string to any unexpected prompt. This
will trigger an "abort: response expected" exception from the server, which
is easily handled as a CommandError, and subsequent commands sent from the
same client work as expected.
This doesn't completely resolve bug 5516, as unexpected requests on another
required channel (e.g. I) can still cause a lockup.
However, it does fix the most common case of an unexpected password prompt.
author | G?bor Stefanik <gabor.stefanik@nng.com> |
---|---|
date | Tue, 12 Sep 2017 13:16:36 -0400 |
parents | 6564544576b9 |
children | 8341f2494b3f |
line wrap: on
line source
import os, sys, tempfile, shutil import unittest import hglib from hglib import client def resultappender(list): def decorator(f): def decorated(*args, **kwargs): list.append(args[0]) return f(*args, **kwargs) return decorated return decorator class basetest(unittest.TestCase): def setUp(self): self._testtmp = os.environ["TESTTMP"] = os.environ["HOME"] = \ os.path.join(os.environ["HGTMP"], self.__class__.__name__) self.clients = [] self._oldopen = hglib.client.hgclient.open # hglib.open = resultappender(self.clients)(hglib.open) c = hglib.client.hgclient c.open = resultappender(self.clients)(c.open) os.mkdir(self._testtmp) os.chdir(self._testtmp) # until we can run norepo commands in the cmdserver os.system('hg init') self.client = hglib.open() def tearDown(self): # on Windows we cannot rmtree before closing all instances # because of used files hglib.client.hgclient.open = self._oldopen for client in self.clients: if client.server is not None: client.close() os.chdir('..') try: shutil.rmtree(self._testtmp) except AttributeError: pass # if our setUp was overriden def append(self, path, *args): f = open(path, 'ab') for a in args: f.write(a.encode('latin-1')) f.close()