client: fail gracefully on unexpected prompts (issue5516) Right now, if hglib encounters an unexpected prompt, it fails with a rather opaque "unexpected data on required channel 'L'" error message. Furthermore, if subsequently another command is called on the same client instance, both the client and server processes lock up hard (at least on Windows), and the server process rapidly leaks ~2GB of memory. Fix this by responding with an empty string to any unexpected prompt. This will trigger an "abort: response expected" exception from the server, which is easily handled as a CommandError, and subsequent commands sent from the same client work as expected. This doesn't completely resolve bug 5516, as unexpected requests on another required channel (e.g. I) can still cause a lockup. However, it does fix the most common case of an unexpected password prompt.

from tests import common
import hglib

class test_hglib(common.basetest):
    def setUp(self):
        pass

    def test_close_fds(self):
        """A weird Python bug that has something to do to inherited file
        descriptors, see http://bugs.python.org/issue12786
        """
        common.basetest.setUp(self)
        client2 = hglib.open()
        self.client.close()

    def test_open_nonexistent(self):
        # setup stuff necessary for basetest.tearDown()
        self.clients = []
        self._oldopen = hglib.client.hgclient.open
        try:
            self.clients.append(hglib.open('inexistent'))
            # hg 3.5 can't report error (fixed by 7332bf4ae959)
            #self.fail('ServerError not raised')
        except hglib.error.ServerError as inst:
            self.assertTrue('inexistent' in str(inst))